RiotGames / developer-relations

Riot Games Developer Ecosystem Bug Reporting
http://developer.riotgames.com
734 stars 44 forks source link

[BUG][DOCS] undocumented `match-v5.ParticipantDto` fields #754

Open MingweiSamuel opened 1 year ago

MingweiSamuel commented 1 year ago

scroll to bottom for latest

old content ## Ping fields all `integer`s (I assume): * `allInPings` * `assistMePings` * `baitPings` * `basicPings` * `commandPings` * `dangerPings` * `enemyMissingPings` * `enemyVisionPings` * `holdPings` * `needVisionPings` * `onMyWayPings` * `pushPings` * `visionClearedPings` And other field: * `eligibleForProgression`: `boolean` ## More integer fields (new 2023-04-19) * `totalAllyJungleMinionsKilled` * `totalEnemyJungleMinionsKilled` ## More integer fields (2023-06-13) * `subteamPlacement` * `playerAugment1` * `playerAugment2` * `playerAugment3` * `playerAugment4` * `playerSubteamId` ## ~~[A new nested object field: (2023-11-09) (comment)](https://github.com/RiotGames/developer-relations/issues/754#issuecomment-1804745635)~~ FIXED 2024-05-10 ```json "missions": { "playerScore0": 0, "playerScore1": 0, "playerScore10": 0, "playerScore11": 0, "playerScore2": 0, "playerScore3": 0, "playerScore4": 0, "playerScore5": 0, "playerScore6": 0, "playerScore7": 0, "playerScore8": 0, "playerScore9": 0 }, ``` However the fields are also included directly in the participants dto too (???) * `playerScore0` * `playerScore1` * `playerScore10` * `playerScore11` * `playerScore2` * `playerScore3` * `playerScore4` * `playerScore5` * `playerScore6` * `playerScore7` * `playerScore8` * `playerScore9` ## New riot game name field (renamed from `riotIdName`?) (2023-11-22) * `riotIdGameName`: `String` ## 2024-06-11 JP1_450685262 * `playerAugment5` * `playerAugment6`
MingweiSamuel commented 1 year ago

Alright thats all of em for across JP1_390614378 JP1_390621320 JP1_390576646 JP1_390626149 JP1_390607492 JP1_390638767 JP1_390609829 JP1_390643123

geozukunft commented 1 year ago

The ping fields got introduced with the start of preseason so that should be 12.22 or 12.23 iirc

As for the progression field I am not entirely sure when that one got added

MingweiSamuel commented 1 year ago

More integer fields (new 2023/04/19)

DarkIntaqt commented 1 year ago

New (integer) fields:

Hand picked, maybe I missed some

MingweiSamuel commented 1 year ago

Oh yeah, forgot to add those here

https://github.com/MingweiSamuel/riotapi-schema/commit/fe02503a1367c755f92091864626b0627c4b0c3d

geozukunft commented 9 months ago

Got some new stuff found in a quick play game EUW1_6669686325

"missions": {
                    "playerScore0": 0,
                    "playerScore1": 0,
                    "playerScore10": 0,
                    "playerScore11": 0,
                    "playerScore2": 0,
                    "playerScore3": 0,
                    "playerScore4": 0,
                    "playerScore5": 0,
                    "playerScore6": 0,
                    "playerScore7": 0,
                    "playerScore8": 0,
                    "playerScore9": 0
                },
MingweiSamuel commented 9 months ago

Any idea what the meaning of the array is? Why 12 entries?

geozukunft commented 9 months ago

no clue and for some reason those 12 values are also present as part of the participantDTO without being in the missions subcatgeory

MingweiSamuel commented 9 months ago

match-v5.ParticipantDto.riotIdGameName: String

Querijn commented 9 months ago

Any idea what the meaning of the array is? Why 12 entries?

Only thing that springs to mind is the max known amount of players in a game (hexakill, 6v6)

MingweiSamuel commented 3 months ago

Missions DTO now exists

MingweiSamuel commented 3 months ago

These fields are now documented:

'riotIdName'
'riotIdGameName'
'allInPings'
'assistMePings'
'commandPings'
'dangerPings'
'enemyMissingPings'
'enemyVisionPings'
'getBackPings'
'needVisionPings'
'onMyWayPings'
'pushPings'
'visionClearedPings'
'eligibleForProgression'
'challenges'
'totalAllyJungleMinionsKilled'
'totalEnemyJungleMinionsKilled'
'playerAugment1'
'playerAugment2'
'playerAugment3'
'playerAugment4'
'playerSubteamId'
'subteamPlacement'
'placement'
MingweiSamuel commented 3 months ago

The following are still missing: "baitPings","basicPings","holdPings","playerScore0","playerScore1","playerScore10","playerScore11","playerScore2","playerScore3","playerScore4","playerScore5","playerScore6","playerScore7","playerScore8","playerScore9"

IchiruTake commented 3 months ago

I want to give some updates here Date: May 24th 2024

-- UNKNOWN -- : My query match doesn't list these entries, but for "holdPings" and "playerScore*" are document available baitPings basicPings

For "riotIdName", this field is not listed in my ARAM gameplay yesterday .

MingweiSamuel commented 2 months ago

2024-06-11

JP1_450685262

f3ar161 commented 2 months ago

Hi @MingweiSamuel could you verify the ParticipantDto, all fields were updated.

MingweiSamuel commented 1 month ago

The dangerPings field was removed from the docs even though it is still being returned (always zero: https://github.com/RiotGames/developer-relations/issues/870 )

MingweiSamuel commented 1 month ago

Sorry for the delay @f3ar161

Hi @MingweiSamuel could you verify the ParticipantDto, all fields were updated.

The following fields are still missing from the docs for match-v5.ParticipantDto

And that is all, currently!