RiotGames / developer-relations

Riot Games Developer Ecosystem Bug Reporting
http://developer.riotgames.com
739 stars 44 forks source link

[BUG] VAL-MATCH-V1 Chamber Ultimate eliminations have no weapon identifier #799

Open reuhreuh opened 1 year ago

reuhreuh commented 1 year ago

Bug Description
When Chamber makes an elimination with its ultimate "Tour de Force", damageItem identifier is missing in the FinishingDamageDto.

Problem Description For every kills with Chamber Ultimate, the VAL-MATCH-V1 endpoint returns an incomplete FinishingDamageDto.

Expected Result I don't know the reason, but the "Tour de Force" Chamber ultimate used to be seen as a regular weapon, with 39099fb5-4293-def4-1e09-2e9080ce7456 uuid. For every Chamber eliminations using its Ultimate, we used to have following FinishingDamageDto value :

"finishingDamage": {    
    "damageType": "Weapon",    
    "damageItem": "39099fb5-4293-def4-1e09-2e9080ce7456",    
    "isSecondaryFireMode": true    
}

Actual Result
For every Chamber eliminations using its ultimate we have following FinishingDamageDto value :

"finishingDamage": {    
    "damageType": "Weapon",    
    "damageItem": "",    
    "isSecondaryFireMode": true    
}

Developer Impact
Eliminations statistics can't be computed.

Frequency Every API call.

Issue Comments
I don't understand why some agents like Jett or Raze have FinishingDamageDto with a damageType": "Ultimate", while Neon and Chamber ultimate eliminations have "damageType": "Weapon". This is not consistent and tools computing player performance statistics per agent / weapons / abilities are hard to maintain.

serkanbal commented 3 months ago

Hello, do we have an update on this issue? Any idea when it may be fixed?

reuhreuh commented 1 week ago

Hi, this issue has been fixed.

Chamber Tour de Force

                            "finishingDamage": {
                                "damageType": "Weapon",
                                "damageItem": "39099FB5-4293-DEF4-1E09-2E9080CE7456",
                                "isSecondaryFireMode": true
                            }

Chamber Head Hunter

                            "finishingDamage": {
                                "damageType": "Weapon",
                                "damageItem": "856D9A7E-4B06-DC37-15DC-9D809C37CB90",
                                "isSecondaryFireMode": true
                            }

Neon Overdrive

                            "finishingDamage": {
                                "damageType": "Weapon",
                                "damageItem": "95336AE4-45D4-1032-CFAF-6BAD01910607",
                                "isSecondaryFireMode": false
                            }

Thank you !