RiotGames / developer-relations

Riot Games Developer Ecosystem Bug Reporting
http://developer.riotgames.com
746 stars 44 forks source link

[DOCS] Clarify what `gameEndedInEarlySurrender` field means in match-v5 API #818

Open chulman444 opened 1 year ago

chulman444 commented 1 year ago

Bug Description
Its vagueness in name and lack of description has confused many developers.

Problem Description
Spread of non-official information on how you can tell if a game is a remake or not with game duration:

But this has been 'verified' by a user who collects his matches or has his own data or something in 2011:

Lists 235s=3m55s and 248s=4m8s games with gameEndedInEarlySurrender: true, but even with this non-official information is spread, at least on Discord.

Expected Result
No confusion on what gameEndedInEarlySurrender is. Either rename it to be isRemake or something, or add description like "if gameEndedInEarlySurrender is true, it means there was a summoner who disconnected, and that team agreed to remake the game."

Actual Result
Nothing. Vague field name, no discription.

Developer Impact
Misinformation and non-official information spread for almost 2 years or more.

The field name becoming useless.

Player Impact
Well ... in game won't have impact, but if players decided to use a website that uitilized misinformation, the players would be confused.

Preconditions
A dev wants to know how to know if a game was a remake, because doc is missing information.

Issue Comments
The 235s and 248s games that someone else posted is missing match id. Besides remake games with more than 3min or 3m30s, I have the following matches that support my opinion that gameEndedInEarlySurrender: true means a remake:

I just want to see actual remake games that are past 3m30sec in duration.

From Fandom wiki "surrendering > remake" says:

Casting a remake vote is available from at least 1:30 and until at most 3:29 game time (when the 90 consecutive seconds of idling are completed by 1:30 and 2:59, respectively) for teams to decide if they want to remake a game or not.

And it also says that

Initiating a surrender vote will display a pop-up menu of the type of surrender for 60 seconds.

So the latest remake game is longer than 4m29s if the vote was initiated at 3:29 and ended at 4m29s. And adding that extra time before the Nexus goes boom.

Please add description. Rito

tisbells commented 1 year ago

Hi - I'll see what clarification I can get and comment back when I have additional info!

ThreeHoolagins commented 8 months ago

Hi @tisbells, and progress on this?

tisbells commented 6 months ago

Hi! Here is what I've heard:

gameEndedInEarlySurrender refers to games that are remakes. Remakes can only occur when a player is disconnected/AFK for more than 90 seconds in the first 3 minutes of the game.

A remake can only occur if the game was terminated in the first 3 minutes of the game. Any surrender after that will be recorded as a loss. When a player goes AFK after 3 minutes, the other players on the team have the option to surrender, but it will be counted as a loss. Some more information about remakes can be found here.

The team is aware the field name is misleading and they hope to update this in the future, but for now we will update the description in our docs.