search

RiotGames / developer-relations

Riot Games Developer Ecosystem Bug Reporting
http://developer.riotgames.com
737 stars 44 forks source link

Naming of data dragon champion tile images is inconsistent #83

Open meesvandongen opened 5 years ago

meesvandongen commented 5 years ago

Fiddlesticks does not work as champion key: https://ddragon.leagueoflegends.com/cdn/img/champion/tiles/Fiddlesticks_0.jpg //does not work https://ddragon.leagueoflegends.com/cdn/img/champion/tiles/FiddleSticks_0.jpg //does work https://ddragon.leagueoflegends.com/cdn/img/champion/tiles/fiddlesticks_0.jpg //does work

Ddragon tile images are named inconsistently. The latest champions (Sylas and Neeko) have only been uploaded with champion key (where it was previously only full lowercase, I believe).

Not really a big problem, but still annoying.

KonssnoK commented 9 months ago

how we doing 3 years later fellas? http://ddragon.leagueoflegends.com/cdn/13.24.1/img/champion/FiddleSticks.png vs https://ddragon.leagueoflegends.com/cdn/13.24.1/img/champion/Fiddlesticks.png

Querijn commented 9 months ago

Hey! Thanks for responding.

Fiddlesticks lists his image name as "Fiddlesticks.png" in http://ddragon.leagueoflegends.com/cdn/13.24.1/data/en_US/champion.json. That seems to match your case, right? Am I missing something? Seems like this issue is unrelated.

KonssnoK commented 9 months ago

sorry i had to be more specific. match data championName reports fiddlestick name as FiddleSticks, while in the ddragon data the image is under Fiddlesticks, suggesting that the inconsistencies are still there :)

Querijn commented 9 months ago

That's not this issue. This issue is that the tiles image have several images with the same case-insensitive name, and no reference from the champion.json to the right one.

Your issue is that the key of the Riot API (not mentioned in the original issue) does not case-sensitively match the key of the champion image, nor the key of the one in champion.json.

Querijn commented 9 months ago

This is the solution to your issue, on top of using championId rather than championName: https://github.com/RiotGames/developer-relations/issues/7#issuecomment-445104648

KonssnoK commented 9 months ago

Wow, ok, I didn't expect to have to go through an additional layer. Thanks!