RiotGames / developer-relations

Riot Games Developer Ecosystem Bug Reporting
http://developer.riotgames.com
742 stars 44 forks source link

[BUG] `statsJson` removed from `.ROFL` replay files in patch 13.20 #831

Open Resinderate opened 11 months ago

Resinderate commented 11 months ago

Previous to patch 13.20, when you download and parse a .ROFL file it contains some metadata about the game. This included the statsJSON which gave most (but not all compared to the API) of the details around the game.

For replays downloaded after patch 13.20, it looks like this has been removed and now just has an empty value (of []).

Is this a planned change moving forward? Any reason to remove this?

Why is this an issue?

This is related to some of the other issues raised here around the v4 -> v5 match API around custom games. I help run a community site for a twitch streamer, where we play lots of custom games together. We track the stats to provide leaderboards etc.

These games are not available via the API as there is not OAuth solution yet. As a workaround, I've been instead using replay files. We get a player in that game to download the replay file from their client, and upload for us to parse. This is now not possible.

An alternative here is using the LCU, but is perhaps not as easy. This would require creating an app for users to download and run to upload their games while running the league client. This is obviously a bigger barrier than just uploading a replay file.

Resinderate commented 11 months ago

The stats for reference look something like this:

[
  {
    "ID": "29101329",
    "EXP": "17906",
    "WIN": "Win",
    "NAME": "...",
    "PING": "24",
    "SKIN": "Graves",
    "TEAM": "100",
    "ITEM0": "2421",
    "ITEM1": "3071",
    "ITEM2": "3078",
    "ITEM3": "3111",
    "ITEM4": "3156",
    "ITEM5": "6676",
    "ITEM6": "3364",
    "LEVEL": "17",
    "PERK0": "8021",
    "PERK1": "9111",
    ...
    },
    ...
]

but now just have an empty value of [].

geozukunft commented 11 months ago

Extracting data from rofl files is not offficially supported so I wouldn't expect a fix on this one

Maybe this is just a prestep to finally get RSO support in match-v5 for custom games

Querijn commented 11 months ago

Hey! I actually ran into the same issue. Thanks for reporting it here.

I've forwarded it to Riot Dev Rel, which in turn has let the team know. I'm purely guessing here, but seeing the reaction and follow-up questions, it might be that this was not an intentional change.

Resinderate commented 11 months ago

Maybe this is just a prestep to finally get RSO support in match-v5 for custom games

Here's hoping, that would be ideal 😄

mazetuski commented 11 months ago

I have the same problem, I have a free tool for amateur esports, and I use rofl files to upload data from private scrims.

Since patch 13.20 I can't get this information

ToryYR commented 11 months ago

I too am experiencing the same problem. If you have any helpful information, please let me know.

Querijn commented 11 months ago

The playback metadata has the game ID in it. If you know the platform in question (which is in the filename), you could try to look it up with the Riot Games API. This does not work for custom games.

ToryYR commented 11 months ago

@Querijn I also used Riot API. However, this is data from a custom game Do you know of any good methods for custom games?

Querijn commented 11 months ago

Nope.

Querijn commented 11 months ago

This was not an intentional change, I hear.

Querijn commented 11 months ago

Confirmed still an issue: a current rofl with gameVersion "13.21.537.9010" is missing data still.

neeemo commented 11 months ago

I sadly secondly confirm that the stats are still missing.

tisbells commented 11 months ago

Hey there - I can't provide an exact date but we expect this to be resolved in the next few weeks.

neeemo commented 11 months ago

Hey there - I can't provide an exact date but we expect this to be resolved in the next few weeks.

That's great! Thanks for the update.

Querijn commented 11 months ago

Ran a 13.22.541.1765 practice tool game, statsJson was present. Replay: EUW1-6667566920.zip

Querijn commented 9 months ago

Found issue again in 13.24: 13.24 akshan e.rofl.zip

Seems like you need to end the game to get a statsJson output.