RiotGames / developer-relations

Riot Games Developer Ecosystem Bug Reporting
http://developer.riotgames.com
744 stars 44 forks source link

[BUG] champion-mastery-v4 does not support updated champion mastery system #930

Open Derpthemeus opened 5 months ago

Derpthemeus commented 5 months ago

The champion mastery system was updated but champion-mastery-v4 does not support the changes.

MingweiSamuel commented 5 months ago

(related #915: the markRequiredForNextLevel and championSeasonMilestone fields were briefly returned but are not anymore)

MingweiSamuel commented 5 months ago

There's (undocumented) stuff now!

    {
        "puuid": "bJ_-UdX8v1NqvsUemuklcmd70lNjgDY0UN81L75d84HneX8dHy8iteZC49qEkJVPvGzJZC4R-89dHA",
        "championId": 143,
        "championLevel": 90,
        "championPoints": 1001446,
        "lastPlayTime": 1715882051000,
        "championPointsSinceLastLevel": 45846,
        "championPointsUntilNextLevel": -34846,
        "markRequiredForNextLevel": 2,
        "chestGranted": false,
        "tokensEarned": 0,
        "championSeasonMilestone": 0,
        "milestoneGrades": [
            "S+"
        ],
        "nextSeasonMilestone": {
            "requireGradeCounts": {
                "B-": 1,
                "C-": 4
            },
            "rewardMarks": 1,
            "bonus": false,
            "rewardConfig": {
                "rewardValue": "5f4333db-e90d-4705-903b-08dbf5e61006",
                "rewardType": "HEXTECH_CHEST",
                "maximumReward": 7
            }
        },
        "summonerId": "4tsApe4ybBLv39VISPsFm4uS_45M-J-d2HC39mmoCvIUlFHU"
    },

New fields are markRequiredForNextLevel (#915) championSeasonMilestone (#915) milestoneGrades: List[String] (OPTIONAL) nextSeasonMilestone

nextSeasonMilestone schema ```json "champion-mastery-v4.NextSeasonMilestone": { "type": "object", "title": "NextSeasonMilestone", "properties": { "requireGradeCounts": { "type": "object", "x-key": { "type": "string", "x-type": "string" }, "additionalProperties": { "type": "integer", "format": "int32", "x-type": "int" }, "x-type": "Map[string, int]" }, "rewardMarks": { "type": "integer", "format": "int32", "x-type": "int" }, "bonus": { "type": "boolean", "x-type": "boolean" }, "rewardConfig": { "$ref": "#/components/schemas/champion-mastery-v4.RewardConfig", "x-type": "RewardConfig" } }, "required": [ "requireGradeCounts", "rewardMarks", "bonus", "rewardConfig" ] }, "champion-mastery-v4.RewardConfig": { "type": "object", "title": "RewardConfig", "properties": { "rewardValue": { "type": "string", "x-type": "string" }, "rewardType": { "type": "string", "x-type": "string" }, "maximumReward": { "type": "integer", "format": "int32", "x-type": "int" } }, "required": [ "rewardValue", "rewardType", "maximumReward" ] } ```
tisbells commented 5 months ago

Hey there - we spoke to the team and this is as designed. Here is what they said-

We'll also be getting the docs updated soon to reflect the field changes mentioned above.

omarali commented 5 months ago

Would it be possible for the team to add a boolean that indicates if a champion is part of the seasonal mastery set? It would be very convenient to be able to check on our mastery set progress during champ select instead of having to manually copy that information from the collections tab before the game.

MingweiSamuel commented 5 months ago

chestGranted listed in the docs is no longer returned by the API

AoshiW commented 4 months ago

any update @tisbells ?

MingweiSamuel commented 4 months ago

requireGradeCounts should be Map[string, integer] but is just documented as object

MingweiSamuel commented 3 months ago

NextSeasonMilestoneDTO docs are missingly a newly returned int field totalGamesRequires