updated http/tcp clients to ensure timeouts are set

RiotGames / key-conjurer

Temporary Credential Service

Apache License 2.0

167 stars 33 forks source link

Closed riot-jetaylor closed 5 years ago

riot-jetaylor commented 5 years ago

Updated all HTTP clients to have a timeout set.

Also, removed the reusable httpClient and generate a fresh one each time.

riot-jetaylor commented 5 years ago

Should we have it be a configureable amount or just a const thats at the top of the file?

rnikoopour commented 5 years ago

I'd like a single constant to represent all timeouts. Something in consts.go. Thoughts?

That way it could be overridden during compilation like we do with the other vars there.

riot-jetaylor commented 5 years ago

@rnikoopour this look better?