search

RiotGames / key-conjurer

Temporary Credential Service
https://technology.riotgames.com/news/key-conjurer-our-policy-least-privilege
Apache License 2.0
167 stars 33 forks source link

Configuration and CLI improvements using Viper #83

Closed punmechanic closed 11 months ago

punmechanic commented 1 year ago

This pull request makes two changes to the user CLI:

  1. It adds the much esteemed spf13/viper to complement spf13/cobra. Configuration loading and saving is now handled entirely through Viper. The rationale behind this change is that Viper is more fully-featured out of the box than our hacked together solution.
  2. Remove --short-version and --long-version, replacing them with a condensed --version flag.
artem-smotrakov commented 1 year ago

2. Remove --short-version and --long-version, replacing them with a condensed --version flag.

Hey @fnickels If I understand correctly, you added --short-version to use in some automation

https://github.com/RiotGames/key-conjurer/pull/79

Is it okay for you to replace it with --version? Can you have a look at this PR please?

punmechanic commented 1 year ago

I’ll be pulling that change from this PR

Sent from Proton Mail for iOS

On Thu, Nov 10, 2022 at 03:24, Artem Smotrakov @.***> wrote:

  1. Remove --short-version and --long-version, replacing them with a condensed --version flag.

Hey @.***(https://github.com/fnickels) If I understand correctly, you added --short-version to use in some automation

#79

Is it okay for you to replace it with --version? Can you have a look at this PR please?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

punmechanic commented 1 year ago

Oh, I should have marked this as a draft PR, sorry

fnickels commented 1 year ago
  1. Remove --short-version and --long-version, replacing them with a condensed --version flag.

Hey @fnickels If I understand correctly, you added --short-version to use in some automation

79

Is it okay for you to replace it with --version? Can you have a look at this PR please?

Totally fine with this change, did not want to break backward compatibility with my previous changes, love the adoption of the one-line '--version' format. I don't think these changes will break anything internally that I was working on. Poke me when it goes live internally and I will double-check to make sure my team's tooling is clean.