search

RiotGamesCookbooks / artifact-cookbook

Provides your cookbooks with the Artifact Deploy LWRP
Other
134 stars 91 forks source link

Allow artifact_file to handle snapshot and latest version correctly (V2 !) #128

Closed BarthV closed 10 years ago

BarthV commented 10 years ago

Hi !

I've cleaned up my previous PR and I have taken into account the comments and requests. I successfully tested many update/upgrade/downgrade/init scenarios from Nexus.

Please test and review this work.

PS : I know some if tests may be quite long ... Perhaps it would be interesting to simplify this into a def

BarthV commented 10 years ago

Target file is now renamed with provided name during the process.

BarthV commented 10 years ago

Roger that, I'll update this 2 tests using artifact method calls

BarthV commented 10 years ago

I'll verify checksuming tomorrow, retest and fix if needed. (It was OK when i tested this so far .. But I could have missed something) Thx for the review btw

BarthV commented 10 years ago

updated. Previous comments are now fixed.

KAllan357 commented 10 years ago

This looks good for now, though I do agree that the if statements are getting a bit crazy. :+1:, but I think I'd like to see us revisit this whole Provider and see if it can be streamlined a bit.

TYVM for the contribution!

bdemers commented 10 years ago

Works Here! Got an ETA on the next release ?

KAllan357 commented 10 years ago

I'd like to see most of the 2.0.0 milestones closed before we cut a release. To me, the big ones are #113, #57 (in general, some updates / support for Chef 11). I also thought I had an issue to refactor the data bag loading logic to simplify it, but I can't seem to find that.

BarthV commented 10 years ago

Do you need some help to work on #113 & #57 ? I'll be happy to have a new release for this CB too :smiley_cat: