RiotGamesCookbooks / artifact-cookbook

Provides your cookbooks with the Artifact Deploy LWRP
Other
134 stars 91 forks source link

use_symlinks option to deploy without symlinks #147

Closed florentdupont closed 10 years ago

florentdupont commented 10 years ago

I'd like to propose a feature that could allow a deployment without the use of symlinks.

This feature could be available through a new parameter called use_symlinks (default to true). The behavior of any artifact deployment stays the same if the option is not set or set to true (default value).

If use_symlinks is false then no symlinks are used for the deployment but are still following the releases/current/shared convention, which means :

Here's a schema explaining the differences between the two options :

symlinks_differences

This feature is actually developed (and used) internally with an older version of the artifact-cookbook (1.3.1). We are planning to merge this modification soon to version 1.12.1 (still internally). We'd like to pull-request this feature to help people to use older OSes that don't support symlinks (Windows 2003 for instance) to perform an artifact deployment this way.

Do you think we could perform a pull-request and if it's gonna be accepted ? Any question, improvement is welcomed.

KAllan357 commented 10 years ago

:+1: - I think this is a great idea. For Riot we've only needed to support Unix and Windows 2008R2 - both of which support symlinks (or junctions).

I'm all for supporting other OSes with the optional attribute you describe.

florentdupont commented 10 years ago

merged in PR #150