search

RiotGamesMinions / motherbrain

An orchestrator for Chef
Other
119 stars 18 forks source link

if i ctrl+c a motherbrain command it should release the lock for that environment #81

Closed jhowarth closed 11 years ago

reset commented 11 years ago

@jhowarth @justincampbell this can easily be fixed by making MB::ChefMutex to a Celluloid::FSM and using the finalize method to unlock when the actor is shutting down

justincampbell commented 11 years ago

@reset ChefMutex is already an actor. I'm running into an issue where the locks manager and ridley are both shutting down before the mutex has a chance to unlock itself. I'm exploring/tweaking our supervision hierarchy, but no luck yet.

reset commented 11 years ago

@justincampbell good work. I think we have a definitive problem around the shutdown sequence of the application; if you could solve this it would be amazing.

justincampbell commented 11 years ago

I'll start working on this now that #192 is ready

justincampbell commented 11 years ago

@jhowarth @reset I'm having problems with this. It seems like whatever I do, the connection is lost before we trap the connection. Might need to trap it in Ridley as well? Is this worth working on right now, assuming #248 gets merged?

reset commented 11 years ago

@justincampbell while it's useful, it's probably more of an annoyance than a necessity for this sprint if we have the lock and unlock commands

reset commented 11 years ago

Closing since we have the lock and unlock command (#248). I think it's best for the environment to remain locked if CTRL-C is sent and then explicitly unlocked with these commands.