search

RiotGamesMinions / riot-redline-plugin

An operating system agnostic Maven plugin for creating RPMs.
Apache License 2.0
6 stars 7 forks source link

Rpm signing #10

Closed TorstenS73 closed 10 years ago

TorstenS73 commented 10 years ago

Here is the implementation. Maybe it will make sense to add a test-case as well and polish the documentation a bit.

KAllan357 commented 10 years ago

Looks like this doesn't merge cleanly. I'm thinking perhaps you need to merge upstream changes into your branch.

KAllan357 commented 10 years ago

Implements https://github.com/RiotGames/riot-redline-plugin/issues/9

KAllan357 commented 10 years ago

It looks like the pom.xml got pretty messed up. I think the indentation got doubled or switched from spaces to tabs. If that gets fixed up, I'm :+1:

TorstenS73 commented 10 years ago

We want identation by 4 spaces, don't we? IIUC, the pull request updates itself automatically, doesn't it? I have pushed a commit with a new pom.xml and it seems to show up here.

KAllan357 commented 10 years ago

4 spaces, yeah. I think this looks better. Anyway, it can always be autoformatted if needed. Thanks for the contribution!!