RiotGamesMinions / riot-redline-plugin

An operating system agnostic Maven plugin for creating RPMs.
Apache License 2.0
6 stars 7 forks source link

Implemented the ability to specify file permissions #13

Closed hatchy closed 9 years ago

hatchy commented 9 years ago

This is the implementation of #12, allowing developers to specify the permissions of the files in the built RPM.

We have switched the integration testing language to BeanShell as we were having trouble getting the Groovy scripts working.

To implement this we had to use a newer version of Redline, which has now been published to Maven Central.

Please note we also increased the version of this plugin.

KAllan357 commented 9 years ago

@hatchy, thank you for the contribution! This looks great to me - I'm fine with changing the test to bsh, as long as the coverage is still there. :+1:

cquinn commented 9 years ago

:+1: small suggestions, but looks good either way.