RiotGamesMinions / riot-redline-plugin

An operating system agnostic Maven plugin for creating RPMs.
Apache License 2.0
6 stars 7 forks source link

Expose RPM signing functionality of Redline library #9

Closed TorstenS73 closed 10 years ago

TorstenS73 commented 10 years ago

The Redline library provides the capability to sign RPM files, which is a requirement to get them uploaded to many repositories.

I am thinking of adding that capability to the riot-redline-plugin, introducing an extension to the plugin configuration like this:

<configuration>
  [...]
  <signature>
    <keyring>secring.gpg</keyring>
    <privateKeyId>foo</privateKeyId>
    <privateKeyPassphrase>redline</privateKeyPassphrase>
  </signature>
  [...]
</configuration>

It would be a bit cleaner actually to do it this way:

<configuration>
  [...]
  <signature>
    <keyring privateKeyId="foo" privateKeyPassphrase="bar">secring.gpg</keyring>
  </signature>
  [...]
</configuration>

Just it would breach with the "way of doing things" in the rest of the plugin, so I'd do the first option.

Comments please ...

KAllan357 commented 10 years ago

I think I prefer the first example in terms of XML syntax.

TorstenS73 commented 10 years ago

Code committed (b2447747e331b522287faedaf1b1dcdbef5f71ef), so we can close that one here as well.