search

RiotGamesMinions / thor-scmversion

Thor tasks to manage a VERSION file based on SCM tags
MIT License
58 stars 22 forks source link

Constrain bumps to branch #22

Closed capoferro closed 11 years ago

capoferro commented 11 years ago

This changes the way tags are read in git, constraining the tags to just the branch currently in use.

If the tag that scmversion is trying to bump to exists, the command will error out (with a friendly message), exiting 100.

Ready for review.

ivey commented 11 years ago

@bluepojo Did you ever solve the issue on this feature? Should we merge anyway?

capoferro commented 11 years ago

@ivey I'm sorting it out just now. Probably shouldn't merge it, even though it's just a test failure.

capoferro commented 11 years ago

@ivey Fixed! I'll open a new PR to fix all the Dir.chdirs to change directories properly.

Still :construction:, though. Going to poke at it more tomorrow if I have time.

capoferro commented 11 years ago

I believe I have the proper approach to filtering tags by branch as of this latest commit. Unfortunately the test suite is rather broken, so I am going to have to spend some time revamping it. It was kinda hacky the way we were doing it before, so it's probably worth refactoring anyway.

capoferro commented 11 years ago

This is no longer under construction. Review welcome.