Revert "Issue #31 - Look up the dir hierarchy for .git dir"

RiotGamesMinions / thor-scmversion

Thor tasks to manage a VERSION file based on SCM tags

MIT License

58 stars 22 forks source link

Revert "Issue #31 - Look up the dir hierarchy for .git dir" #36

Closed ivey closed 10 years ago

ivey commented 10 years ago

Reverts RiotGames/thor-scmversion#34

This code breaks p4 support, has no tests, and also doesn't make sense to me. Reverting, but we should take another stab at it.

KAllan357 commented 10 years ago

:+1:

jchauncey commented 10 years ago

Or original intent was around the fact that our cookbooks (using the environment cookbook pattern) lived with our source. So you would have

/foo /foo/cookbook /foo/src

We wanted the thorfile to live in /foo/cookbook but this would fail because /foo/cookbook did not contain a .git directory. thor-scmversion should look up the directory structure until it finds a corresponding .git directory to determine if it's a git project.