search

RiotGear / rg-router

State based router for Riot apps
MIT License
28 stars 3 forks source link

Filter non serializable properties before saving state #7

Closed andrefgneves closed 8 years ago

gregorypratt commented 8 years ago

The router should wait for the resolve method to complete before moving onto the state. https://github.com/RiotGear/rg-router#add

This works when you go to state or refresh the page, but it doesn't when the back button is used since its removed from state on save.

andrefgneves commented 8 years ago

Ops, sorry about that. I did that change in a hurry and couldn't properly test it. It believe it will work fine now.

Can you please check again?

gregorypratt commented 8 years ago

Right cool, I've manually merged and updated the code ;-)

Thank you so much for your time on this!

gregorypratt commented 8 years ago

If you're happy I'll publish v1.3.0 to NPM :+1:

andrefgneves commented 8 years ago

My pleasure :) Yes, please do.