search

RiotGear / rg

The open source component library for RiotJS
http://riotgear.js.org/
MIT License
297 stars 67 forks source link

rg-tags not working with riot 3.x.x #118

Open DenLilleMand opened 7 years ago

DenLilleMand commented 7 years ago

Hi, i just stumbled across the fact that rg-tags are still relying on the name implementation instead of ref. So it stopped working when i updated my Riot.js. I had to update riot because i had some really weird mistakes that we're fixed by updating. So i am thinking about rewriting that component with the ref instead. I could make a pull request, but i suppose that you're keep riot 2.x compatible components seperate from the 3.x compatible ones, or how does this work??

adavie1 commented 7 years ago

Thanks, I'll look into that. I've not yet updated the components to Riot v3.xx.

faststare08 commented 5 years ago

any update this issue?

DenLilleMand commented 5 years ago

Hi @faststare08

My solution back then was to create a custom tags solution, i have copied it into a gist for your convenience: https://gist.github.com/DenLilleMand/ff7fd30b94c5a9866d5e85cded69a0e9

The solution is tied into a store that fetches suggestions/auto-completions for tags in a async fashion, that part can of course just be cut out of the tag implementation it self, as far as i can see i have attempted to do a generic implementation that should work with all sorts of tags.

I cannot speak on behalf of the maintainers of course, but it looks like the last code related commit is pretty old, i simply dont know if they would accept a PR. Also looks like the forks are not being any more active than this repo: http://forked.yannick.io/RiotGear/rg

faststare08 commented 5 years ago

thank for the reference.

adavie1 commented 5 years ago

Hi all, the site has not been updated to Riot 3 yet. At this point I've got a lot of work on VueJS projects. I will come back and update here later on. Thanks for your patience and support.