custom tag in rg-modal is not evaluated

RiotGear / rg

The open source component library for RiotJS

http://riotgear.js.org/

MIT License

297 stars 67 forks source link

custom tag in rg-modal is not evaluated #63

Closed ghost closed 8 years ago

ghost commented 8 years ago

Hi,

thanks for your great library.

While playing around I found a possible bug: If the content of a button is set to an html string which contains a riot tag, the tag is not evaluated correctly. I get the custom tag inside the button, but its html is empty.

Any help is appreciated, thanks.

gregorypratt commented 8 years ago

Right that's a scenario I never thought about! I think I could wrap a riot compile in the rg-raw tag to fix this. It would also fix it in other content: "" instances...watch this space

gregorypratt commented 8 years ago

Actually I think we'll need to wait until v2.4.0 of Riot is released to make use of the additional compiler APIs

gregorypratt commented 8 years ago

Does this work now?

Example: https://plnkr.co/edit/35HE8BJtzfEdp5b42vtX?p=preview

EDIT: Actually I misread your issue. The v3 modal doesn't even allow HTML in the buttons so this isn't a problem anymore...