<rg-chart> crashes on `unmount`

RiotGear / rg

The open source component library for RiotJS

http://riotgear.js.org/

MIT License

297 stars 67 forks source link

<rg-chart> crashes on `unmount` #97

Closed stukennedy closed 8 years ago

stukennedy commented 8 years ago

there is a call to chart.destroy() which crashes the app when the <rg-chart> tag unmounts.

This is because the object passed to the loaded event handler is the wrong object, and should be the result of creating a chart, not just new Chart(ctx)

gregorypratt commented 8 years ago

fixed in v3.3.2, thanks for the PR