Can't update the program

RipMeApp / ripme

Downloads albums in bulk

MIT License

3.72k stars 630 forks source link

Can't update the program #1027

Closed ModokiMokona closed 5 years ago

ModokiMokona commented 6 years ago

Ripme version: 1.7.68 (and some previous ones)
Java version: 10.0.2
Operating system: Windows ver. 10.0.17134.345
Please include any additional information about how to reproduce the problem: Whenever the program checks for updates on start-up or after clicking "check for updates".

Expected Behavior

RipMe downloads the newest version and performs the update automatically.

Actual Behavior

File "ripme.jar.update" is downloaded, but the program still displays the "Downloading new version..." message. The only way to perform the update is by manually downloading the new version.

cyian-1756 commented 6 years ago

Can you run the program from the command line, try to update and post the output?

ModokiMokona commented 6 years ago

Sure: screenshot 2018-10-28 21 11 26

Ouxhi commented 6 years ago

I've been having this same issue for awhile now. It began several updates ago but I just started to get the releases from github instead.

cyian-1756 commented 6 years ago

After some googling it looks like the class I used for performing the checksum on downloaded updates isn't by default part of java version 9 or above.

Until I putout an update you should by able to fix this by starting ripme with java --add-modules java.xml.bind -jar ripme.jar

bossman762x39 commented 5 years ago

same here on macbook pro has been several updates that i have to come here to download new version delete old.

cyian-1756 commented 5 years ago

In the rederenced PR I changed the updater so it no longer uses HexBinaryAdapter, and it will be changed for the 1.7.70 release (You'll still have to download that release manually however)

cyian-1756 commented 5 years ago

I put out the 1.7.70 release