RipMeApp / ripme

Downloads albums in bulk
MIT License
3.72k stars 630 forks source link

Pornhub ripper is excessively slow #1121

Open skier233 opened 5 years ago

skier233 commented 5 years ago

Expected Behavior

Detail the expected behavior here.

Should be much faster

Actual Behavior

Detail the actual (incorrect) behavior here. You can post log snippets or attach log files to your issue report.

The threading in pornhubripper isn't actually accomplishing anything. A thread is created and code is ran on it. However, then thread.sleep is called for the entire duration of how long that thread will run. Thus, this performance is the same or worse as it if didn't use threading at all. This code desperately needs some performance enhancements.

buzzlightmonth commented 5 years ago

I believe Pornhub limits downloads to somewhere around 100kb/s, and no amount of threads can really beat that (I don't think they allow for download resuming either).