search

RipMeApp / ripme

Downloads albums in bulk
MIT License
3.72k stars 631 forks source link

Add RedGIF Support #1654

Open yothrowawaytoday opened 4 years ago

yothrowawaytoday commented 4 years ago

Expected Behavior

Successfully download GIFs from RedGIFs.

Actual Behavior

RipMe says there is no compatible ripper found.

NSFW Reddit users are moving from Gfycat to RedGIF

https://www.reddit.com/r/redgifs/comments/e9fosv/welcome_to_redgifscom/

avekifes commented 4 years ago

Shouldn't this take less than a minute to add, since it's basically Gfycat?...

yothrowawaytoday commented 4 years ago

Shouldn't this take less than a minute to add, since it's basically Gfycat?...

Some Reddit mobile app developers have already updated their apps to be compatible or have planned to release it in their next version release. So this makes me agree with you. I do not think it would take too much effort to add. I've probably been missing some content as well.

cinnamonbubblegum commented 4 years ago

Working on a PR now

seattle255 commented 4 years ago

@pmuybae Thank you!!!!!

avekifes commented 4 years ago

So, I'm kind of clueless as to how these things play out. I'm seeing that the pull request was successful, so does this mean we're just waiting for someone to update the release?

avekifes commented 4 years ago

What is the hold-up with this? Seems like borderline232 and pmuybae both submitted working versions.

reasonabledoubt commented 4 years ago

@avekifes, @pmuybae didn't submit anything yet and you can follow along with the status of @borderline232's submission at https://github.com/RipMeApp/ripme/pull/1672 (which is still under active discussion).

If you want something that probably works right now (and are interested in testing and reporting back here your findings), you can compile @kepler-421b's version at https://github.com/kepler-421b/ripme which incorporates changes by @michaeln914 so that reddit posts containing redgifs links will also get saved.

cinnamonbubblegum commented 4 years ago

I did here but due to #1663 I can't really work on it

reasonabledoubt commented 4 years ago

@pmuybae, it looks like the @borderline232 PR at #1672 has been tested and is working.