RipMeApp / ripme

Downloads albums in bulk
MIT License
3.7k stars 629 forks source link

Redgifs issue with . in username #1786

Open bloodaxis opened 3 years ago

bloodaxis commented 3 years ago

Expected Behavior

Expected behavior is to download the mp4s of the clips.

Actual Behavior

As you can see in the attached picture/log it tries to download from https://www.redgifs.com/users/katie rather than the correct katie.anders username.

javaw ripme.log

borderline232 commented 3 years ago

If you want to do this yourself, you can add a dot to the regex found here https://github.com/RipMeApp/ripme/blob/e0d40df5adc6618d962d939edaba8ed620f1bd78/src/main/java/com/rarchives/ripme/ripper/rippers/RedgifsRipper.java#L57-L60 to ^https?://[wm.]*redgifs\\.com/users/([a-zA-Z0-9_.-]+).*$ which will detect the dot in usernames

If you don't know how to do this, then I'll try and update my fork (https://github.com/borderline232/ripme) with this change, because the owner of this ripme takes a while to update sometimes, so you can try it there.

bloodaxis commented 3 years ago

Yeah I've got no clue how anything works here so I'll wait for you to update yours. 👍

borderline232 commented 3 years ago

@bloodaxis Alright, I've added those changes to the newest release on my fork here (https://github.com/borderline232/ripme/releases/tag/1.7.96) lemme know if you have any issues