RipMeApp / ripme

Downloads albums in bulk
MIT License
3.67k stars 624 forks source link

Change behavior of closing dialog with hitting X #1976

Open Attacktive opened 2 years ago

Attacktive commented 2 years ago

https://github.com/RipMeApp/ripme/issues/1975

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

Description

I simply changed the behavior to close the dialog instead of terminating the application itself.

Technically, mvn test failed.

Boot Manifest-JAR contains absolute paths in classpath 'X:\WORKING\DIRECTORY\target\test-classes' Hint: -Djdk.net.URLClassPath.disableClassPathURLCheck=true

But it doesn't seem relevant to my changes and did fail with the HEAD version, too.

Testing

Required verification:

Optional but recommended:

soloturn commented 2 years ago

merged here: https://github.com/ripmeapp2/ripme/releases.