RipMeApp / ripme

Downloads albums in bulk

MIT License

3.71k stars 629 forks source link

Fix for nhentai changing image URLs #1978

Closed kleptoc closed 2 years ago

kleptoc commented 2 years ago

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

[x] a bug fix (Fix #1963 )
[ ] a new Ripper
[ ] a refactoring
[ ] a style change/fix
[ ] a new feature

Description

Fix for new(?) nhentai image URLs causing 403 errors

Testing

Required verification:

[x] I've verified that there are no regressions in mvn test (there are no new failures or errors).
[x] I've verified that this change works as intended.
- [x] Downloads all relevant content.
- [x] Downloads content from multiple pages (as necessary or appropriate).
- [x] Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
[x] I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

[ ] I've added a unit test to cover my change.

kleptoc commented 2 years ago

All test failures were present before my code change.

soloturn commented 2 years ago

applied here: https://github.com/ripmeapp2/ripme/releases