RipMeApp / ripme

Downloads albums in bulk
MIT License
3.72k stars 631 forks source link

Instagram Ripper download by tag broken. #288

Closed ERasnier closed 6 years ago

ERasnier commented 6 years ago

Detail the expected behavior here.

Didn't download anything and skipped to next job.

Detail the actual (incorrect) behavior here. You can post log snippets or attach log files to your issue report. Spat out: JSONObject["__typename"] not found.

rautamiekka commented 6 years ago

Even if your ridiculously old Java isn't to blame, I'd damn well update it.

cyian-1756 commented 6 years ago

@rautamiekka

Even if your ridiculously old Java isn't to blame

The java version isn't to blame here, tags haven't been fully implemented yet because they're a PIA to work with

metaprime commented 6 years ago

@rautamiekka please moderate your comments about outdated Java versions.

Yes, outdated Java is bad. It's okay to indicate that there's a newer version and make a constructive recommendation to update. However, continuously ridiculing folks who are trying to identify and report issues in ripme is not helpful to the project's community, especially when it's pretty clear from running a test on your own version of ripme that the issue repros and the version of Java is not to blame.

It would be very helpful for us if you could direct your energy to confirm or NoRepro bug reports.

metaprime commented 6 years ago

@cyian-1756 if we decide we explicitly do not want to support this we should have the regex reject this URL format (e.g. "expected URL format " like we do for other rippers) -- that's what I'd label as the bug here if anything. Otherwise if we'd like to support this, we can update this issue to enhancement.

cyian-1756 commented 6 years ago

if we decide we explicitly do not want to support this we should have the regex reject this URL format

No need to not support it, it's possible to do I just haven't gotten around to it yet

we can update this issue to enhancement

I say do that

cyian-1756 commented 6 years ago

This was fixed quite a few versions ago