RipMeApp / ripme

Downloads albums in bulk
MIT License
3.72k stars 631 forks source link

[NSFW] Won't work with searches in NSFW subreddits #357

Open ShittyGuy opened 6 years ago

ShittyGuy commented 6 years ago

If I am trying to download all images which appear from a search on a non-NSFW subreddit it will download all of them how it should be. For example https://www.reddit.com/r/wallpapers/search?q=tree&restrict_sr=on

But if I am trying to download all the images from a search in an NSFW subreddit like /r/ImGoingToHellForThis it just says "Rip complete, saved to \rips\reddit_sub_ImGoingToHellForThis" without doing anything. For example https://www.reddit.com/r/ImGoingToHellForThis/search?q=test&restrict_sr=on&include_over_18=on&sort=relevance&t=all

Would be nice if it could be fixed.

cyian-1756 commented 6 years ago

Reddit is weridly returning {"kind": "Listing", "data": {"after": null, "whitelist_status": "promo_adult_nsfw", "facets": {}, "modhash": "", "children": [], "before": null}} when I hit https://www.reddit.com/r/ImGoingToHellForThis/search.json?q=test&restrict_sr=on&include_over_18=on&sort=relevance&t=all

This might be an api change.

Edit: Yea this is an api change. You now need to accept a cookie to search nsfw subs. I guess it's about time for ripme to switch to reddits Oauth api

metaprime commented 6 years ago

Or possibly a candidate for cookie support, but non cookies is easier if we can.