RipMeApp / ripme

Downloads albums in bulk
MIT License
3.71k stars 629 forks source link

Instagram Ripper only getting first page #474

Closed thinkpad4 closed 6 years ago

thinkpad4 commented 6 years ago

@cyian-1756

Actual Behavior

Bug.txt That is what it is doing, I've tried several different instagram sites. Detail the actual (incorrect) behavior here. You can post log snippets or attach log files to your issue report.

cyian-1756 commented 6 years ago

Does anyone have any idea why this regex won't work? Because I'm completely stumped

 Pattern jsP = Pattern.compile("queryId:\"([a-zA-Z0-9]+)\"");
 Matcher m = jsP.matcher("queryId:\"TEST\"");
 return m.group(1);

Edit: Looks like pattern.compile didn't like the \"

thinkpad4 commented 6 years ago

Was the \ the issue that bugged it?

cyian-1756 commented 6 years ago

Was the \ the issue that bugged it?

No idea, I just replaced the \" with a . wildcard

cyian-1756 commented 6 years ago

This was fixed in 1.7.26

thinkpad4 commented 6 years ago

@cyian-1756 Thank you SO much for fixing this. I'm gonna tell you, it seems to rip faster now, like a LOT faster

cyian-1756 commented 6 years ago

I'm gonna tell you, it seems to rip faster now

It's because it can get more images per page. Before IG only returned something like 30 images a page, but now it returns up to 500.