RipMeApp / ripme

Downloads albums in bulk
MIT License
3.7k stars 629 forks source link

GUI opens when trying to run 1.7.29 via command line #497

Closed clb92 closed 6 years ago

clb92 commented 6 years ago

Expected Behavior

I expect it to start ripping, outputting status in the command line, like any previous version did.

Actual Behavior

The command line outputs:

Loaded C:\Users\Christoffer\AppData\Local\ripme\rip.properties
Loaded log4j.properties
Initialized ripme v1.7.29

And then the GUI opens, and nothing is ripped (unless I manually do it in the GUI). Screenshot

clb92 commented 6 years ago

I can force it to detect as headless by doing this:

java -Djava.awt.headless=true -jar ripme.jar -u '<any URL here>'

I think the problem is that the code no longer uses arguments to determine if it should run headless, which is a problem when we want to run it headless on a system that supports the GUI.

heyhippari commented 6 years ago

Indeed, this seems to be an issue.

I'll push a fix for it ASAP.

heyhippari commented 6 years ago

Feel free to compile the branch headless-fix on my fork while waiting for this to get merged in.

You need a JDK and Maven, then simply ./build.sh or ./build.bat and it should output you a .jar in the target subdirectory.

clb92 commented 6 years ago

Thanks!

Should I close this issue in the mean time?

heyhippari commented 6 years ago

It'll auto-close once it's merged in, usually, so you can leave it open.