RipMeApp / ripme

Downloads albums in bulk
MIT License
3.68k stars 625 forks source link

Ripme should have translations #569

Open cyian-1756 opened 6 years ago

cyian-1756 commented 6 years ago

Right now ripmes UI and log are English only, some work should be put in to translate them into various other languages (I say we should start with Spanish as that seems to ripme current largest non-English userbase)

rautamiekka commented 6 years ago

I could do the Finnish part ...

Isaaku commented 6 years ago

I could translate it to spanish but who is gonna do the base for the locale?

El mié., 9 de may. de 2018 a la(s) 15:19, Jouni Järvinen < notifications@github.com> escribió:

I could do the Finnish part ...

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/RipMeApp/ripme/issues/569#issuecomment-387862968, or mute the thread https://github.com/notifications/unsubscribe-auth/AF8qcxxy-3p1l68wodTsJNMjXeQtNPS9ks5tw09QgaJpZM4T4cS0 .

cyian-1756 commented 6 years ago

@Isaaku

but who is gonna do the base for the locale?

You mind explaining what you mean?

Isaaku commented 6 years ago

I mean the use of the ResourceBundle. I think i could do it in the sunday https://docs.oracle.com/javase/tutorial/i18n/resbundle/propfile.html

http://www.avajava.com/tutorials/lessons/how-do-i-use-locales-and-resource-bundles-to-internationalize-my-application.html

El mié., 9 de may. de 2018 a la(s) 19:16, cyian-1756 < notifications@github.com> escribió:

@Isaaku https://github.com/Isaaku

but who is gonna do the base for the locale?

You mind explaining what you mean?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/RipMeApp/ripme/issues/569#issuecomment-387912863, or mute the thread https://github.com/notifications/unsubscribe-auth/AF8qc3AntXBrXVzHIXrLSOOC-FyVunnXks5tw4bWgaJpZM4T4cS0 .

cyian-1756 commented 6 years ago

I mean the use of the ResourceBundle

I mean whoever want to can. I'll get started on it today or tomorrow and then make a PR

cyian-1756 commented 6 years ago

I've started work on this here in this branch

Edit: It's all being done in master

Isaaku commented 6 years ago

I try to push the changes to a branch but it seens that i can't

2018-05-12 01_19_32-ripme v1 7 44

Commit Message: LabelsBundle in spanish (Mising spellings checks and some labels) LabelsBundle_es_ES.zip

cyian-1756 commented 6 years ago

I try to push the changes to a branch but it seens that i can't

Did you try to push to this branch or a repro that you own?

Anyhow thanks for the translation! It should be in the next version of ripme

WeWin55 commented 6 years ago

Ive added German translation. One version with umlauts äöü and the other without it. I dont know how your code will react on öäü. If there is a problem, let me know.

LabelsBundle.properties_de_DE.zip

TheRec commented 6 years ago

Created a PR for French (Switzerland) translation: https://github.com/RipMeApp/ripme/pull/580

As noted in the PR, currently RipMe only supports Latin1/ANSI characters so the format of the added file is ANSI. If UTF8 support is implemented this should be converted.

It goes for @WeWin55 translation too, if the version with umlauts is saved in ANSI they should be displayed correctly.

Lastly, as pointed out in the PR too, translations for different countries with the same language should maybe work as a fallback when the exact couple language/country of the user does not exist. Or maybe allow to force the language with an application setting.

cyian-1756 commented 6 years ago

@TheRec

As noted in the PR, currently RipMe only supports Latin1/ANSI characters so the format of the added file is ANSI

As of 1fe3f10 ResourceBundles are now read as UTF-8

translations for different countries with the same language should maybe work as a fallback when the exact couple language/country of the user does not exist

That's a good idea

Or maybe allow to force the language with an application setting.

That's also a good idea

rautamiekka commented 6 years ago

I'll try to do the translation, but Git and GitHub aren't exactly clear-to-use things (I'm not using Git itself, though, only GitHub website) ...

cyian-1756 commented 6 years ago

@rautamiekka

(I'm not using Git itself, though, only GitHub website)

If you can't get it working just attach the file to your comment/post the content of the translation

TheRec commented 6 years ago

@cyian-1756 Nice, I've updated my PR with the UTF-8 version and tested it, works fine with special characters now 👍

biladina commented 6 years ago

Hi, this is translate from Indonesia (Bahasa Indonesia). I don't know how to use git push, so I upload here.. LabelsBundle_id_ID.properties.zip

rautamiekka commented 6 years ago

Here are 2 Finnish translations:

Standard:

Log = Logi
History = Historia
created = luotu
modified = muokattu
Queue = Jono
Configuration = Asetukset

# Keys for the Configuration menu

current.version = Nykyinen versio
check.for.updates = Tarkista päivitykset
auto.update = Automaattipäivitys?
max.download.threads = Yhtäaikaiset lataukset
timeout.mill = Aikakatkaisu (millisekunneissa):
retry.download.count = Latauksen uudelleenyritykset
overwrite.existing.files = Korvaa nykyiset tiedostot?
sound.when.rip.completes = Valmistumisääni
preserve.order = Pidä järjestys
save.logs = Tallenna logit
notification.when.rip.starts = Valmistumisilmoitus
save.urls.only = Tallenna vain osoitteet
save.album.titles = Tallenna albumiotsikot
autorip.from.clipboard = Ota linkit leikepöydältä
save.descriptions = Tallenna kuvaukset
prefer.mp4.over.gif = Suosi MP4:jää GIF:fin sijasta
restore.window.position = Palauta ikkunan sijainti
remember.url.history = Muista osoitehistoria
loading.history.from = Ladataan historiaa kohteesta

# Misc UI keys

loading.history.from.configuration = Ladataan historiaa asetustiedostosta
interrupted.while.waiting.to.rip.next.album = Keskeytetty odottaessa seuraavaa albumia
inactive = Toimeton
re-rip.checked = Uudelleenlataa merkatut
remove = Poista
clear = Tyhjennä

My porrisavvo dialect:

Log = Loki
History = Historriijja
created = luatu
modified = muakat
Queue = Jono
Configuration = Assetuksse

# Keys for the Configuration menu

current.version = Nykyne versijjo
check.for.updates = Tarkist update
auto.update = Automaatpäivvitys?
max.download.threads = Yht'aikasse ripi
timeout.mill = Timeout (millisekois):
retry.download.count = Ripi retry count
overwrite.existing.files = Korvvaa nykysse filu?
sound.when.rip.completes = Valmistummis'ään
preserve.order = Pir järestys
save.logs = Tallen loki
notification.when.rip.starts = Valmistummisilmotus
save.urls.only = Tallen vaa ossottee
save.album.titles = Tallen album'otsiko
autorip.from.clipboard = Ot linki leikpöyrrält
save.descriptions = Tallen kuvvauksse
prefer.mp4.over.gif = Suasi MP4 GIF sijjaa
restore.window.position = Palaut ikkunna sijaant
remember.url.history = Muist osot'hissa
loading.history.from = Larrataa hissaa lähteest

# Misc UI keys

loading.history.from.configuration = Larrataa hissaa asetusfilust
interrupted.while.waiting.to.rip.next.album = Keskeytet venates seurraavvaa album
inactive = Idle
re-rip.checked = Re-rip merkatu
remove = Poist
clear = Tyhjen
kevin51jiang commented 6 years ago

@biladina Thanks for your work!

@rautamiekka Thanks for the multiple translations. Do you know what the short form for "porrisavvo" would be? I've taken a look online and can't find one.

rautamiekka commented 6 years ago

^ @kevin51jiang Never heard of any short forms for Finnish dialects and slangs. Or any language, for that matter.

kevin51jiang commented 6 years ago

@rautamiekka Like how English's short form is EN, or French is FR, Spanish is ES etc.

Do you know if your dialect has something like that?

rautamiekka commented 6 years ago

@kevin51jiang That's what I meant. If there even is such a code for any of the official Finnish dialects or slangs, I'm not aware of one.

metaprime commented 6 years ago

Standard Finnish (ISO 639-1language code fi) as used in Finland (ISO 3166 country code FI) is fi-FI.

metaprime commented 6 years ago

I can't find any information about a dialect called "porrisavvo" or any variant thereof, but you'd be surprised at what you can find in the linguistic sphere if you know what you're looking for. @rautamiekka can you find a Wikipedia page in Finnish about your dialect or anything like that? What is your dialect called in English, or Standard Finnish, or the dialect itself? Is it in the same language family as Finnish, or more related to Romani, or something else?

kevin51jiang commented 6 years ago

Do they fit in with anything on this website?

rautamiekka commented 6 years ago

You should give up looking for a code for porrisavvo since that dialect was created by me, I never submitted to any place (the syntax is a WIP), and there's no way to translate it cuz the 2-part name is made from the dialectic names of the cities (Pori, Savo) the master dialects are from, out of which I created the dialect.

@kevin51jiang No match on that site.

zinuzian commented 6 years ago

I've made Korean translation. :) May I create a PR?

cyian-1756 commented 6 years ago

While we're at it we should translate the readme and wiki

rautamiekka commented 6 years ago

^ How're we gonna translate the wiki ?

cyian-1756 commented 6 years ago

@rautamiekka

How're we gonna translate the wiki ?

Translate the page and name the translated version $Pagename_$langcode. So if you were to translate Config-options.md into Korean it would become Config-options_kr_KR.md

nfrelink commented 6 years ago

I dont exactly know how to submit this as a PR. I have added Dutch translations.

LabelsBundle_nl_NL.zip

Kelleidorn commented 5 years ago

Russian translation:

LabelsBundle_ru_RU.zip

cyian-1756 commented 5 years ago

Hey everyone, I've added some more lines to the base locale that should be translate (commenting in case anyone wants to update the translation they did)

TheRec commented 5 years ago

@cyian-1756 There is a "translation" branch and I used that one last time to create a PR, but it seems that the new strings have not been merged to this branch... do we want to work directly on "master" now or will you merge to "translation"? After further review it seems you've been doing it on "master" and since I had some more fixes (beyond just translation strings) to add I've made a pull request towards "master". See PR #874 ;)

ZielekPL commented 5 years ago

Polish translation: PLtranslation.zip

cyian-1756 commented 5 years ago

@ZielekPL Thanks for the translation but you seem to have used an old base locale and missed a few keys, see here for the update base locale

ZielekPL commented 5 years ago

gonna do it again but which system should I use? UTF-8?

cyian-1756 commented 5 years ago

@ZielekPL Use UTF-8

ZielekPL commented 5 years ago

Sorry 4 soo long waitin but it's finished LabelsBundle_pl_PL.zip