search

RipMeApp / ripme

Downloads albums in bulk
MIT License
3.73k stars 629 forks source link

DeviantArt ripper not ripping descriptions #783

Open Wiiplay123 opened 6 years ago

Wiiplay123 commented 6 years ago

Expected Behavior

Rip descriptions when "Save descriptions" box is checkmarked.

Actual Behavior

Exactly the same thing as having the "Save descriptions" option disabled. No descriptions are saved, only the images are downloaded.

Wiiplay123 commented 6 years ago

Just checked the source code because I was going to try to cram the modern source code into my outdated personal ripme version and realised three things:

  1. The description code for deviantart was COMPLETELY taken out when it was updated for some reason
  2. It would be REALLY hard to put the new code into the old code
  3. New RipMe throws enough invalid session cookies to lock my IP out of my deviantArt account for 3-4 days, but that might be because of the initial cookies I gave it. :\
cyian-1756 commented 6 years ago

The description code for deviantart was COMPLETELY taken out when it was updated for some reason

It's because the ripper moves from AbstractHTMLRipper (Which can save descriptions) to AbstractJSONRipper (Which currently can't save descriptions)

New RipMe throws enough invalid session cookies to lock my IP out of my deviantArt account for 3-4 days, but that might be because of the initial cookies I gave it. :\

That ought not happen. Are you getting any error messages?

Wiiplay123 commented 6 years ago

No error messages, it just keeps going without being logged in and I get locked out with it saying "Wrong password" and I have to wait 3-4 days without even trying to log in for it to work again :(

Wiiplay123 commented 6 years ago

DeviantArt's about to get a site upgrade, now I'll probably have to modify my personal build of RipMe based on 1.5.2 to be able to rip things again :\