search

RipMeApp / ripme

Downloads albums in bulk
MIT License
3.73k stars 629 forks source link

8Muses ripper cuts portion of album name #898

Open S2andz opened 6 years ago

S2andz commented 6 years ago

Expected Behavior

When downloading albums without the 'Save album titles' option enabled, the album name should be included with the part/issue

Actual Behavior

When downloading the album linked above, the output folder is named 'Part-1-' instead of 'Another-Chance-2---Part-1'

This only happens when the sub folders use the name 'Part-#' instead of the usual 'Issue-#'

For example, when downloading https://www.8muses.com/comics/album/MilfToon-Comics/Mom-Know-Best/Issue-1, the output is named 'Mom-Know-Best---Issue-1 instead of just 'Issue-1'

cyian-1756 commented 6 years ago

I can't reproduce this. Ripping https://www.8muses.com/comics/album/Seiren_com_br-Comics/Another-Chance-2/Part-1 puts the images in 8muses_Another_Chance_2_Part_1/Part-1-

S2andz commented 6 years ago

When I rip https://www.8muses.com/comics/album/Seiren_com_br-Comics/Another-Chance-2/Part-1, with the Save album titles config option disabled, the images are put in 8muses_Seiren_com_br-Comics\Part-1- without the Another-Chance-2 portion of the album name

However, when I rip https://www.8muses.com/comics/album/MilfToon-Comics/After-Party/Issue-1 the images are put in 8muses_MilfToon-Comics\After-Party---Issue-1 where the important part of the comic name is included. That difference where the actual name of the comic isn't placed before the Part-# is the problem I am having

cyian-1756 commented 6 years ago

When I rip https://www.8muses.com/comics/album/Seiren_com_br-Comics/Another-Chance-2/Part-1 with the 'Save album titles' config option disabled

Woops I had Save album titles enabled. I can comfirm that with Save album titles disabled the ripper doesn't include Another-Chance-2

cyian-1756 commented 6 years ago

After a bit of checking it looks like this is an issue with 8muses. The title of https://www.8muses.com/comics/album/Seiren_com_br-Comics/Another-Chance-2/Part-1 is "Part 1" where as https://www.8muses.com/comics/album/MilfToon-Comics/After-Party/Issue-1 is titled "After Party - Issue 1".

I could fix this by just using the url as the folder name when Save album titles is disabled

Why do you have Save album titles disabled anyway? The whole point of it is for situations like these

S2andz commented 6 years ago

It saves a step i guess

When i download frequently updated comics from there with that option is disabled, it just dumps the new pages of the gallery into the parent folder so that i don't have to move and replace files.