One London Bugs/refinement

RippleOSI / OneLondon_OpenPlatform

Project repo wrt OneLondon project ideas

Apache License 2.0

0 stars 0 forks source link

One London Bugs/refinement #5

Closed PhilBarrett closed 5 years ago

PhilBarrett commented 5 years ago

[x] Tunnel positioning too low (Simon)
[x] Responsive issues of background image and logo (Simon) - parked for now
[x] One London logo is stretched in top left (Simon)
[x] Saving doesn't work on edit patient (Bogdan) - 15/20mins
[x] Demographics not returning in SPV Patient Banner (Dima)
[x] CHI number to change back to NHS Number (Bogdan)
[x] Remove Age from MPV view (Bogdan)
[x] Turn off search cog (Bogdan)
[x] Remove rings from headers
[x] clicking from MPV to spv it returns different demographics (parked)

BogdanScherban commented 5 years ago

These issues were done:

Tunnel positioning too low (Simon) CHI number to change back to NHS Number (Bogdan) Remove Age from MPV view (Bogdan) Turn off search cog (Bogdan)

BogdanScherban commented 5 years ago

This issue also has been done:

Saving doesn't work on edit patient (Bogdan) - 15/20mins

simongamester commented 5 years ago

@BogdanScherban Re: One London logo is stretched in top left (Simon) - There appears to be a height attribute on the img tag for the logo. Suggest you remove this. The image is correctly sizes anyway, so needs no widths or sizes set.

kuvakina commented 5 years ago

@PhilBarrett Dima finished with his task. Bogdan'll remove attributes for logo

PhilBarrett commented 5 years ago

Thanks @kuvakina I believe Bogdan and Simon have discussed the background image too, so an update here would be helpful when he finishes the logo attribute change please

BogdanScherban commented 5 years ago

@simongamester @tony-shannon Logo was fixed. Is it OK?