System wide cosmetic style changes to React-Admin showcase

RippleOSI / Ripple-Showcase-Stack-Project

repo for Showcase Stack (PulseTile+ QEWDjs + EtherCIS) - Project issues

Apache License 2.0

0 stars 0 forks source link

System wide cosmetic style changes to React-Admin showcase #23

Closed PhilBarrett closed 5 years ago

kuvakina commented 5 years ago

@tony-shannon @PhilBarrett Bogdan fixed it, could you please check it?

PhilBarrett commented 5 years ago

@kuvakina looking closer, thank you. Please see charts though, this looks very different from React showcase.

kuvakina commented 5 years ago

@BogdanScherban Original Charts looks like this: chart

Charts on Showcase-devra look this way: chart_devra

BogdanScherban commented 5 years ago

Styles fixes, which should be done: 1) Change blocks header to grey 2) Change table header (# , Date, NEWS Score , Source) to green / light green 3) Icons should be in rectangles 4) Sorted column should be highlighted with pale green color 5) Add separate lines for columns 6) Create/Edit buttons should be as rectangle 7) Add sort(up/down)
8) Should date format be 00-Mon-0000 or we can leave 00-00-0000 9) Add space between plugin header and menu header 10) Table highlight lines

tony-shannon commented 5 years ago

which should be done or are done?

kuvakina commented 5 years ago

@tony-shannon Here is an update for style fixes:

[x] Change blocks header to grey
[x] Change table header (# , Date, NEWS Score , Source) to green / light green
[x] Icons should be in rectangles
[x] Sorted column should be highlighted with pale green color
[x] Add separate lines for columns
[x] Create/Edit buttons should be as rectangle
[x] Add sort (up/down)
[x] Add space between plugin header and menu header
[x] Table highlight lines
[x] back button instead of home button in the Topbar
[x] switchers in Vitals-plugin
[ ] Should date format be 00-Mon-0000 or we can leave 00-00-0000 ? @tony-shannon @PhilBarrett

PhilBarrett commented 5 years ago

@simongamester these are some of the changes being made, but sense there are more required following your review

kuvakina commented 5 years ago

@tony-shannon @PhilBarrett @simongamester

All style issues above, except for "Should date format be 00-Mon-0000 or we can leave 00-00-0000 ?", were done. Could you please check it?

Also should I test and compare all plugins and add differences between dev.r.f and showcase-devra.r.f?

PhilBarrett commented 5 years ago

That's fine for now, thanks Alexandra