RippleOSI / Ripple-Showcase-Stack-Project

repo for Showcase Stack (PulseTile+ QEWDjs + EtherCIS) - Project issues
Apache License 2.0
0 stars 0 forks source link

Medium: Panel Spacing and Shadows #40

Closed PhilBarrett closed 5 years ago

PhilBarrett commented 5 years ago

Dashboard widgets should be spaced slightly further apart and shadows should be applied to the outer panel’s div element.

Would recommend increasing the padding of the outer element from 8px to 15px as shown: Screen Shot 2019-05-30 at 15.09.43.png

Apply a box shadow to the panels I think the following would be about right:

Screen Shot 2019-05-30 at 15.10.07.png

BogdanScherban commented 5 years ago

@simongamester

Simon, could you please provide us with screenshots of panels, where we have to add it.

simongamester commented 5 years ago

@BogdanScherban Here's an example of a panel and the DIV we'd like to apply spacing:

Screenshot 2019-05-31 at 10 31 10

Here's the inner DIV where we'd like to apply shadows.

Screenshot 2019-05-31 at 10 30 58

I'm assuming all 'panels' use the same styles, however anything with a green header and white box should adopt the same shadow styling, so this would also include panels containing tables views or records and forms.

BogdanScherban commented 5 years ago

@simongamester

Simon, should it be done ONLY for Showcase? Or for all other projects (Helm, London, Nes) too.

In any case this issue need 0.25-0.5 h

kuvakina commented 5 years ago

@tony-shannon @PhilBarrett @simongamester

Bogdan added Panel Spacing and Shadows: sss6.png

simongamester commented 5 years ago

@BogdanScherban The DIV containing panels also appears to now have a border, see screen...

Screenshot 2019-06-03 at 18 03 01

This means that a line now appears below panels.

Here's the div which I think has the padding applied.

Screenshot 2019-06-03 at 18 02 14

Also, the shadows should be applied to ALL panels through the system. This should not just include widgets as shown above but also panels containg table lists and and record information.

simongamester commented 5 years ago

@BogdanScherban I've just spotted another issue with the panels, which may be related to this Issue: The Create panels for Procedures, Transfers of Care, and Vitals appear to have no white background and no borders, see below...

Screenshot 2019-06-04 at 09.54.38.png

Screenshot 2019-06-04 at 09.54.49.png

Screenshot 2019-06-04 at 09.54.43.png

BogdanScherban commented 5 years ago

@simongamester

This issue has been done: https://drive.google.com/file/d/1TCDSq7fWhUXWlM-2mgNo7Jl3MZVjFhEb/view

simongamester commented 5 years ago

@BogdanScherban I can see you've added the white backgrounds, however the borders are still missing.

BogdanScherban commented 5 years ago

@simongamester

Sorry, Simon. Probably, I sent old video. Look:

Screenshot from 2019-06-05 12-46-39.png Screenshot from 2019-06-05 12-46-49.png Screenshot from 2019-06-05 12-46-59.png

Screenshot from 2019-06-05 12-47-09.png Screenshot from 2019-06-05 12-47-16.png Screenshot from 2019-06-05 12-47-25.png

simongamester commented 5 years ago

Thanks @BogdanScherban, looks good.

@PhilBarrett ok to mark as resolved.