Low: Patient Summary Address

[PhilBarrett]

It looks like the address is in a different DIV to the patient name, but I’m not sure why this is.

In some cases the patient’s doctor is displayed immediately below the name, however when this is blank, it creates a large space which increases the height of the patient summary unnescessarily.

I would suggest moving the address to immediately follow the patient’s doctor on a new line.

[BogdanScherban]

@simongamester

Address line was located in the separate div below, to give possibility to locate doctor info below the patient name.

Or you suggest to locate patient name, doctor and address in one div (vertical direction)?

[simongamester]

That's correct. All 3 fields would be within the same div. If doctor is not provided however, the address would automatically fall directly underneath the patient name.

[BogdanScherban]

OK, I need in 0.5 h for this issue.

[kuvakina]

@tony-shannon @PhilBarrett @simongamester

Bogdan changed it:

[simongamester]

@PhilBarrett Do we have an example of a patient with a doctor? Would be worth testing this before signing this off.

[PhilBarrett]

@tony-shannon if it's been taken from NES work, I don't believe Doctor is in the address, so would need adding in to check

[kuvakina]

Sorry, @PhilBarrett @simongamester could we consider this task as done?

[simongamester]

Could @BogdanScherban send a screen with the Doctor field populated please? We have no way of confirming this field is being displayed correctly as none of the users in the showcase system have the Doctor field. A screenshot taken from dev would suffice.

[BogdanScherban]

@simongamester

Simon, doctor field was presented in the old Showcase (with ReactJS). It was possible, because server side returned infor about doctor:

But in Showcase-RA we use other request for user information, and doctor's info is absent here generally:

For this reason I can't display info about doctor.

But I changed structure of this block according to your suggestion: https://github.com/PulseTile/PulseTile-RA/blob/b8f13b912114f1aa50b67e45aab776827ddf7940/src/core/common/Topbar/fragments/PatientBanner.js#L26

[simongamester]

Thanks @BogdanScherban

For the purposes of testing, I'd like to see this field displayed on the screen, so could you tweak your local copy temporarily so the doctor code block is called?

If you add a line below here, for example:

https://github.com/PulseTile/PulseTile-RA/blob/b8f13b912114f1aa50b67e45aab776827ddf7940/src/core/common/Topbar/fragments/PatientBanner.js#L23

Which manually overrides the 'doctor' variable so calls the doctor to be displayed:

Something like: doctor = 'Daniels Yvonne C.';

Then run the code, take a screenshot and remove the changes.

[BogdanScherban]

@simongamester OK, I added doctor (for test)

[simongamester]

Thanks @BogdanScherban that looks fine to me.

@PhilBarrett this is done.