RippleOSI / Ripple-Showcase-Stack-Project

repo for Showcase Stack (PulseTile+ QEWDjs + EtherCIS) - Project issues
Apache License 2.0
0 stars 0 forks source link

Replace Icons at SPV headings #52

Closed PhilBarrett closed 5 years ago

PhilBarrett commented 5 years ago

Currently like this

Screen Shot 2019-05-30 at 15.36.13.png

Needs to go back to this as per React showcase

Screen Shot 2019-05-30 at 15.35.19.png

BogdanScherban commented 5 years ago

@PhilBarrett @tony-shannon This issue has been done: Screenshot from 2019-06-05 13-41-45

PhilBarrett commented 5 years ago

@simongamester are there icons we can use in the React-admin version (thinking font awesome) that replicate the filter and expand icons from the old showcase

React-Admin showcase that needs to change Screen Shot 2019-06-06 at 11.19.53.png

to react.js showcase Screen Shot 2019-06-06 at 11.19.45.png

BogdanScherban commented 5 years ago

@simongamester @PhilBarrett

We used icons from these free library: https://material.io/tools/icons/?icon=3d_rotation&style=baseline https://fontawesome.com/icons?d=gallery

But we didn't find required free icons, and used presented.

simongamester commented 5 years ago

@PhilBarrett Yes, assuming the react-admin version uses FontAwesome 5, you could use the following:

To expand full screen: https://fontawesome.com/icons/expand-alt?style=solid

Then to collapse full screen: https://fontawesome.com/icons/compress-alt?style=solid

Filter icon can be found here: https://fontawesome.com/icons/filter?style=solid

I'm not sure how Bogdan has coded the icon into the UI, but you can either do this with html e.g.

or by applying css to the element:

div:before { font-family: 'FontAwesome'; content: '\f0b0'; }

simongamester commented 5 years ago

Maybe you're using version 4?

Expand in v4 https://fontawesome.com/v4.7.0/icon/expand

Collapse in v4 https://fontawesome.com/v4.7.0/icon/compress

Filter: https://fontawesome.com/v4.7.0/icon/filter

BogdanScherban commented 5 years ago

@PhilBarrett @tony-shannon

The issue has been done: Screenshot from 2019-06-10 17-20-09.png

PhilBarrett commented 5 years ago

Reviewed and working fine.