search

RippleOSI / Ripple-Showcase-Stack-Project

repo for Showcase Stack (PulseTile+ QEWDjs + EtherCIS) - Project issues
Apache License 2.0
0 stars 0 forks source link

Search refinement #88

Open PhilBarrett opened 5 years ago

PhilBarrett commented 5 years ago

Screen Shot 2019-06-26 at 10.38.55.png

kuvakina commented 5 years ago

There is no clear way to cleardown the advanced search / clinical search. Needs to replicate the behaviour of basic search with an (x) to clear down

@PhilBarrett sorry, not quite understand where you mean (x). I compared 2 versions of the showcase, they work the same. Please, see the video: https://drive.google.com/file/d/1i0x1tOFTyobMTUPMogC17WpjgYVXNAyu/view

Or I checked the wrong place?

Searching by NHS# doesn't return the right value

Also couldn't reproduce the error. Please see the video: https://drive.google.com/file/d/1f7au3pwY9UpLwh6k22VJXaGR3t2nWFFh/view

Encountering an error when trying multiple searches (see screenshot)

I can't reproduce the error, could you please write the steps when you meet this error?

tony-shannon commented 5 years ago

Advanced Search isnt working- to be completed

kuvakina commented 5 years ago

@tony-shannon you mean Advanced search working only with 1 parameter? And if we implement second - it would be ignored?

PhilBarrett commented 5 years ago

@kuvakina

can you add the advanced search scenarios here as agreed yesterday.

Thanks

kuvakina commented 5 years ago

@PhilBarrett we had some thoughts regarding Advanced search: qqq12

1) Search by NHS# When we search by NHS#, we would see only one result as NHS# is unique for each patient. So we think we don't need to add search by Age Range/DOB or Gender

2-3) Search by Surname/Name In original Showcase.r.f. we must fill in both Surname and Name. But could it be that the doctor might not remember the Name, so we think we should add the possibility to search separately either by Surname or by Name. And also in this search should be a possibility to add a parameter to search by Age Range and by Gender (as in original Showcase.r.f.)

4) Search by Age Range In original Showcase.r.f. we can search either by NHS# or by Surname+Name. But what if doctor need to see patients of the concrete age range? Should we make (leave on showcase-devra) separate search by Age Range and with additional search by Gender (Surname/Name, NHS#)?

5) Search by DOB A search by DOB - is this used in general? Are doctors remember DOB of patients?

6) Search by Gender Should we make (leave on showcase-devra) separate search by Gender with additional search by Age Range (Surname/Name, NHS#)

@DmitrySolyannik I didn't miss anything?

kuvakina commented 5 years ago

Also, @PhilBarrett I had some problems to recreate the issue you mentioned above. Could you comment on them, please?

kuvakina commented 5 years ago

@tony-shannon @PhilBarrett We removed case sensitivity for search by surname. You can see the result in the video: https://drive.google.com/file/d/1tulp4lSllu5-Ie47dlL_dCwPh80lBs7Z/view

As for case sensitivity for Clinical search, we can't change it as this search come through EtherCIS, and there should be identical heading names. We should discuss it with EtherCIS team.

Also, we had some questions re Advanced search and few other. Could you please have a look?

There is no clear way to cleardown the advanced search / clinical search. Needs to replicate the behaviour of basic search with an (x) to clear down

@PhilBarrett sorry, not quite understand where you mean (x). I compared 2 versions of the showcase, they work the same. Please, see the video: https://drive.google.com/file/d/1i0x1tOFTyobMTUPMogC17WpjgYVXNAyu/view

Or I checked the wrong place?

Searching by NHS# doesn't return the right value

Also couldn't reproduce the error. Please see the video: https://drive.google.com/file/d/1f7au3pwY9UpLwh6k22VJXaGR3t2nWFFh/view

Encountering an error when trying multiple searches (see screenshot)

I can't reproduce the error, could you please write the steps when you meet this error?

freshehr commented 5 years ago

@kuvakina -can you post the AQL that is sent to Ethercis for a clinical query where case-sensitivity is an issue?

kuvakina commented 5 years ago

Ian @freshehr , here:

select e/ehr_id/value as ehrId, e/ehr_status/subject/external_ref/id/value as nhsNo from EHR e contains COMPOSITION a contains EVALUATION a_a[openEHR-EHR-EVALUATION.adverse_reaction_risk.v1] where a/name/value='Adverse reaction list' and a_a/data[at0001]/items[at0002]/value/value like '%Seafood%'

kuvakina commented 5 years ago

From Ian @freshehr :

try ilike rather than like

select e/ehr_id/value as ehrId, e/ehr_status/subject/external_ref/id/value as nhsNo from EHR e contains COMPOSITION a contains EVALUATION a_a[openEHR-EHR-EVALUATION.adverse_reaction_risk.v1] where a/name/value='Adverse reaction list' and a_a/data[at0001]/items[at0002]/value/value ilike '%Seafood%'

tony-shannon commented 5 years ago

@kuvakina please report on search functionality , what is working/what is broken If suggestions for further improvement , please share estimates

kuvakina commented 5 years ago

Basic search

https://drive.google.com/file/d/1dzu5Mm5ktZAOdy6k_tcS2UbubTLukfzP/view

On the video, you can see that Basic search by surname works and not case sensitive. bs1

Basic search by NHS# NOT working on Showcase-devra.

kuvakina commented 5 years ago

Advanced search

Advanced search works correctly.

by NHS

Search: as1

by surname

Search: as2

by name

Search: as2 4

by age range

Search: as3

by gender

Search: as4

by DOB

Search (put the date in format mm/dd/yyyy): as5

by surname + by name

Search: as2 2

by name + by age range

Search: as2 6

by name + by DOB

Search: as5 4

by name + by gender

Search: as6 2

by surname + by age range

Search: as2 8

by surname + by DOB

Search: as5 2

by surname + by gender

Search: as6 0

by age range + by gender

Search: as3 4

by DOB + by gender

Search: as5 8

by surname + by age range + by gender

Search: as2 10

by surname + by DOB + by gender

Search: as8 4

by name + by age range + by gender

Search: as7 0

by name + by DOB + by gender

Search: as7 2

by surname + by name + by gender

Search: as8 2

by surname + by name + by DOB

Search: as5 6

by surname + by name + by age range

Search: as8 0

by surname + by name + by DOB + by gender

Search: as7 4

by surname + by name + by age range + by gender

Search: as7 6

kuvakina commented 5 years ago

Clinical Query search

https://drive.google.com/file/d/1UcA5A5qy8RTExfpx4PLS-ODhppgnqMG0/view On the video, you can see that Clinical Query search works correctly for:

  1. (works) by Search Type(any)/Search Query (and not case sensitive)
  2. (works) by Search Type(any)/Search Query + by age range + by gender
  3. (works) by Search Type(any)/Search Query + by age range
  4. (works) by Search Type(any)/Search Query + by gender
  5. (not works) by age range + by gender (user see a message that he has to fill in Search Type/Search Query)
  6. (not works) by age range (user see a message that he has to fill in Search Type/Search Query)
  7. (not works) by gender (user see a message that he has to fill in Search Type/Search Query)
  8. (not works) by DOB + by gender (user see a message that he has to fill in Search Type/Search Query)
  9. (not works) by DOB (user see a message that he has to fill in Search Type/Search Query)

Clinical Query search NOT works correctly for:

  1. by Search Type(any)/Search Query + DOB