RippleOSI / Ripple-Showcase-Stack-Project

repo for Showcase Stack (PulseTile+ QEWDjs + EtherCIS) - Project issues
Apache License 2.0
0 stars 0 forks source link

ReSPECT bug #89

Open PhilBarrett opened 5 years ago

PhilBarrett commented 5 years ago

Versions are out of order, with respect v1 appearing at the top before the latest version (V16), both on the patient summary and in the heading itself.

Screen Shot 2019-06-26 at 10.33.09.png

kuvakina commented 5 years ago

@PhilBarrett could you please check again if you still have this bug? I checked with user Mary Spring (9999997456) - added 2 ReSPECT versions (now she has 6 versions), and I see only last 4 versions, and also I don't see Version 1: 3q3q3.png

PhilBarrett commented 5 years ago

please see 8111133448 @kuvakina

BogdanScherban commented 5 years ago

@tony-shannon @PhilBarrett @DmitrySolyannik

I investigated the reasons of the problem. Server side returns versions array in the order from news to oldest (it is correct behavior). Let's look as example - patientId=9999999801: Screenshot from 2019-07-12 11-55-58.png

For the patientId=8111133448 this rule works too: Screenshot from 2019-07-12 11-53-29.png Screenshot from 2019-07-12 11-53-38.png

But you can see, that this user has two versions with number=1. I assume, that it is the server side error: wrong definition of the new version number

This problem should be solved on the server side.

PhilBarrett commented 5 years ago

Thanks Bogdan, Reassigned to Dima just now to pick up.

kuvakina commented 5 years ago

@tony-shannon @PhilBarrett

I don't think we have a problem here, tbh

I just created 16 new ReSPECT forms for another Patient, and they are shown correctly on Patient Summary: qqq5.png

I think the reason, why we have the issue for patient 8111133448, because the first version was created before we fixed problem with GET/POST on Showcase for ReSPECT plugin (we had the same problem on NES). And for some reason this "wrong" version always up in the list.

My suggestion is to close this task and I create a new test Patient and add relevant info for new test Patient. What do you think about this?

tony-shannon commented 5 years ago

ok do try it please @kuvakina

kuvakina commented 5 years ago

@tony-shannon I'll update the issue when I finish

kuvakina commented 5 years ago

@tony-shannon @PhilBarrett I created new test Patient on Showcase:

Lliam Williams / 8888888000

Could you please provide me with some test data for ReSPECT form?