Overflowing bitshift on architectures where `long` is shorter than `index_t`

Ripser / ripser

Ripser: efficient computation of Vietoris–Rips persistence barcodes

http://ripser.org

MIT License

311 stars 78 forks source link

Overflowing bitshift on architectures where `long` is shorter than `index_t` #25

Closed gspr closed 2 years ago

gspr commented 4 years ago

The 1l in the definition of max_simplex_index should probably be (index_t)1, otherwise the code fails on a bunch of platforms where 1l is 32 bit.

ubauer commented 2 years ago

Thank you! It is fixed now.