Riron / ionic-img-viewer

Ionic 2+ component providing a Twitter inspired experience to visualize pictures.
MIT License
283 stars 118 forks source link

Ionic 3.1.x update #47

Closed leoruhland closed 7 years ago

leoruhland commented 7 years ago

Ionic refactor: https://github.com/driftyco/ionic/commit/59eb9a328d353326540d767921057a887058d66f#diff-398257840976a25db8f35174d4d9d467L5

WolfWalter commented 7 years ago

Works for me. Had to also update angular to 4.0.2 and install ionic-angular 3.1.0 for publishing.

burger1992 commented 7 years ago

same here I was gonna open a PR. thanks @leoruhland

Riron commented 7 years ago

Thanks for the PR 👍 I'll look at it quickly and release a new version as fast as possible.

leoruhland commented 7 years ago

Thank you @Riron, for this amazing component!

RedEars commented 7 years ago

@leoruhland Does it work for you? Your change removed the import error, but when I click on the image nothing happens. Ionic 3.0.1

danielkkelly commented 7 years ago

Tested using 3.1.0 and it works well for us. @leoruhland - thank you!

leoruhland commented 7 years ago

@RedEars Yes, worked with version 3.1.0.

Riron commented 7 years ago

Thanks @leoruhland for the PR 👍