Riron / ionic-img-viewer

Ionic 2+ component providing a Twitter inspired experience to visualize pictures.
MIT License
283 stars 118 forks source link

Plugin stopped working after iOS11 update #93

Open gigocabrera opened 7 years ago

gigocabrera commented 7 years ago

Please provide you version information :

Dependency Version
ionic2 ionic-angular 3.7.1
angular 4.4.3
ionic-img-viewer 2.7.3

Have you checked...

After updating my app to iOS 11 checklist and updating to use the new WKWebView this plugin stopped working.

Any ideas? Do you have a workaround?

Riron commented 7 years ago

Could you give some more details about the problem you experience ? You have an error in the console maybe ? Or nothing happens when you click ?

gigocabrera commented 7 years ago

@Riron I have tried building my app from 2 separate environments and the results are the same. I don't see an errors in the console and nothing happens when I tap on an image. I have tested in browser, simulator and device. Same results. I have been using your plugin for a few months in a production environment and it works like a charm. When I upgraded to the latest ionic and implemented the iOS 11 checklist that's when I noticed the new behavior.

Riron commented 7 years ago

Hmm, your problem really looks like https://github.com/Riron/ionic-img-viewer/issues/90 . Are you using the latest release ? Does clicking on an image do appends anything into your DOM ? if so, it's a style problem.

wesleyxiao commented 6 years ago

i have same problem.

Dependency | Version ionic2 | ionic-angular 3.7.1 ionic-img-viewer | 2.7.3

import { NgModule, ErrorHandler } from '@angular/core';
import { BrowserModule } from '@angular/platform-browser';
import { IonicApp, IonicModule, IonicErrorHandler } from 'ionic-angular';
import { MyApp } from './app.component';

import { AboutPage } from '../pages/about/about';
import { ContactPage } from '../pages/contact/contact';
import { HomePage } from '../pages/home/home';
import { TabsPage } from '../pages/tabs/tabs';

import { StatusBar } from '@ionic-native/status-bar';
import { SplashScreen } from '@ionic-native/splash-screen';
import { RestApiProvider } from '../providers/rest-api/rest-api';

import { IonicImageViewerModule } from 'ionic-img-viewer';

@NgModule({
  declarations: [
    MyApp,
    AboutPage,
    ContactPage,
    HomePage,
    TabsPage
  ],
  imports: [
    BrowserModule,
    IonicImageViewerModule
    ,
     IonicModule.forRoot(MyApp, {     // add lazy load
       preloadModules: true,
       mode: 'ios'
     })
  ],

<p class="text"><img src="http://imageexample.jpg" imageViewer alt=""><span class="image-desc"></span></p>

install everthing is ok, but when i click on image nothing happen.

wesleyxiao commented 6 years ago

ok, just solve the issue, we have to add

import { IonicImageViewerModule } from 'ionic-img-viewer'; and add IonicImageViewerModule to imports

these two code have to add into src/app/app.module.ts and the module.ts of your page which you want image to be view

if only add import to app.module.ts, wouldn't make it work