search

Rise-In / NFT-Minter

The NFT-Minter Project is an open-source, blockchain-based application designed to simplify the NFT creation process. It allows users to upload their NFT images, generate JSON metadata for the NFT, and interact with a dynamic NFT marketplace.
https://mintyournft.vercel.app/
4 stars 5 forks source link

search functionality finish #16

Closed saidarshan27 closed 1 month ago

saidarshan27 commented 1 month ago
  1. Search bar added.
  2. when the search bar gets empty, the state is reset to show all nft cards.
  3. I have moved the API calling logic entirely to NftList.js. This will avoid NftCard component calling API inside a loop, which in itself is a performance issue.
  4. Changed props for NftCard to receive all the required parameters to render, rather just imgHash.
  5. Added a loading text to enhance user experience.

Please review the code and get back to me in the review comments in case of any changes. I will be happy to make those changes.

SahityaRoy commented 1 month ago

@bhupendra-chouhan @neutr0n420 have look into this PR.

bhupendra-chouhan commented 1 month ago

@bhupendra-chouhan @neutr0n420 have look into this PR.

Sure!

bhupendra-chouhan commented 1 month ago

👏 Awesome work @saidarshan27 . Your PR has been successfully merged.