Open RiseMP in Windows Startup

Rise-Software / Rise-Media-Player

One media player for everything you own or stream; whether it's music or videos, online or offline Rise Media Player does it all. And it's beautiful and native with the latest version of WinUI.

GNU General Public License v3.0

1.07k stars 76 forks source link

Open RiseMP in Windows Startup #136

Closed esibruti closed 2 years ago

esibruti commented 2 years ago

Details of Changes Add details of changes here.

Added option to open Rise Media Player in Windows Startup

Validation How did you test these changes?

[ ] Built and ran the app

esibruti commented 2 years ago

@itsWindows11 I need your help. He's not opening. And I need to know how this part is done for him to get the values as it should be

esibruti commented 2 years ago

@YourOrdinaryCat Would you mind helping me get this working? It's just that I'm not able to...

itsWindows11 commented 2 years ago

I'll try to look at this and merge. Thanks for the PR tho. @josephbeattie please don't merge this right now.

Also, please don't mass-ping devs, I or YourOrdinaryCat may be busy at something else.

itsWindows11 commented 2 years ago

You seem to have forgot the most important thing which is the app initialization code so that's why it's not starting up. Lemme try to write some code and request review from @YourOrdinaryCat if possible.

itsWindows11 commented 2 years ago

Hey @esibruti, It needs to be enabled from Task Manager for it to work, I also made some changes and I will commit it rn.

esibruti commented 2 years ago

I'll try to look at this and merge. Thanks for the PR tho. @josephbeattie please don't merge this right now.

Also, please don't mass-ping devs, I or YourOrdinaryCat may be busy at something else.

It was just to make sure they saw this pr. sorry

esibruti commented 2 years ago

As of now, I approved this PR but its not fully ready to be merged yet.

Okay, if I need some modification, I can do it. I'm not sure but I think it has to be synchronized with the last changes made.

itsWindows11 commented 2 years ago

As of now, I approved this PR but its not fully ready to be merged yet.

Okay, if I need some modification, I can do it. I'm not sure but I think it has to be synchronized with the last changes made.

yeah, your branch needs to be updated, also I have to request a review from other devs before merging.

itsWindows11 commented 2 years ago

@esibruti can you go to your branch on github and sync it with the changes in the main branch here?

esibruti commented 2 years ago

@itsWindows11 done

itsWindows11 commented 2 years ago

good