search

Rise-Software / Rise-Media-Player

One media player for everything you own or stream; whether it's music or videos, online or offline Rise Media Player does it all. And it's beautiful and native with the latest version of WinUI.
GNU General Public License v3.0
1.07k stars 76 forks source link

MVVM #161

Closed esibruti closed 2 years ago

esibruti commented 2 years ago

Resolved / Related Issues Items resolved / related issues by this PR.

Details of Changes Add details of changes here.

Validation How did you test these changes?

Screenshots / Videos (optional) Add screenshots and/or videos here.

itsWindows11 commented 2 years ago

As I said in our DMs, I will work on it, also there seems to be too many breaking changes and I want to ensure that existing branches here are compatible without doing way too much work, so I'll close this, sorry for the inconvenience.

esibruti commented 2 years ago

As I said in our DMs, I will work on it, also there seems to be too many breaking changes and I want to ensure that existing branches here are compatible without doing way too much work, so I'll close this, sorry for the inconvenience.

@itsWindows11 No problem, I know we talked about it and you were the one who was going to take care of it. I was just doing a test of what it would be like if I did that, it was just with that intention of testing

itsWindows11 commented 2 years ago

As I said in our DMs, I will work on it, also there seems to be too many breaking changes and I want to ensure that existing branches here are compatible without doing way too much work, so I'll close this, sorry for the inconvenience.

@itsWindows11 No problem, I know we talked about it and you were the one who was going to take care of it. I was just doing a test of what it would be like if I did that, it was just with that intention of testing

I know, just don't want some collaborator to accidentally click on the merge button and break everything we did (for example in #159)

esibruti commented 2 years ago

As I said in our DMs, I will work on it, also there seems to be too many breaking changes and I want to ensure that existing branches here are compatible without doing way too much work, so I'll close this, sorry for the inconvenience.

@itsWindows11 No problem, I know we talked about it and you were the one who was going to take care of it. I was just doing a test of what it would be like if I did that, it was just with that intention of testing

I know, just don't want some collaborator to accidentally click on the merge button and break everything we did (for example in #159)

I don't even want to imagine the headache that would be but yes, I understand that. No problem.