Closed YourOrdinaryCat closed 1 year ago
Also it should show "Unknown Artist" for unrecognized artists and hide that for videos.
Playing music then playing a video seems to crash the app with a null reference exception.
Playing music then playing a video seems to crash the app with a null reference exception.
Can't reproduce here, got exception logs? Or maybe more concrete steps, just playing a song then a video works fine here.
Nevermind, fixed it myself, this PR can be merged as-is now.
Resolved / Related Issues Items resolved / related issues by this PR.
Details of Changes The app currently uses the
IMediaItem
interface (implemented bySongViewModel
andVideoViewModel
) to handle media playback and information about currently playing media. However, this is problematic due to the conversions that have to happen betweenIMediaItem
andMediaPlaybackItem
to be able to start media playback. With the current architecture, any scenario where the app has to play media directly from aStorageFile
(e.g drag & drop, file associations) is not possible unless the file is coming from the user's library, which isn't always the case.IMediaItem
Validation
Screenshots / Videos (optional) HQ thumbnails in Now Playing: