search

Rise-Software / Rise-Media-Player

One media player for everything you own or stream; whether it's music or videos, online or offline Rise Media Player does it all. And it's beautiful and native with the latest version of WinUI.
GNU General Public License v3.0
1.06k stars 76 forks source link

Grouping in media lists #222

Closed YourOrdinaryCat closed 1 year ago

YourOrdinaryCat commented 1 year ago

Resolved / Related Issues

Details of Changes This PR replaces the AdvancedCollectionView used for sorting with a new type that allows for both grouping and sorting - GroupedCollectionView. It allows grouping the lists found across the app, and thanks to changes to the way sort descriptions are handled, improves performance.

Validation How did you test these changes?

Screenshots / Videos (optional) SemanticZoom in albums, zoomed out

SemanticZoom in songs, zoomed out

Grouped songs ListView

esibruti commented 1 year ago

I don't know if it's planned but will these options work correctly with this MR?

image

YourOrdinaryCat commented 1 year ago

All of them should work correctly already :) just needs a few fixes to make it more usable.

esibruti commented 1 year ago

Are these options even saved so they don't disappear again? Btw, great job this MR is.

YourOrdinaryCat commented 1 year ago

They should be getting saved for pages that allow for custom sorting (so Songs, Albums, and Videos). Haven't fully checked Videos though, seems like there's a race condition we have to fix because it crashes.

YourOrdinaryCat commented 1 year ago

Are these options even saved so they don't disappear again?

Yes indeed, just fixed the crash and verified, works for songs, albums, and videos :)