search

Rise-Software / Rise-Media-Player

One media player for everything you own or stream; whether it's music or videos, online or offline Rise Media Player does it all. And it's beautiful and native with the latest version of WinUI.
GNU General Public License v3.0
1.07k stars 76 forks source link

Hard-coded version string #85

Closed somnisomni closed 1 year ago

somnisomni commented 2 years ago

There is a hard-coded version string named More_Subtitle in About string resource. Since the hard-coding is not a good practice, even if that is only for devs, I recommend you to use formatting instead hard-code version string. maybe it can formatted with AssemblyVersion or else...?

Hard-coding version string also can make additional dirty changes everytime the program version changes, if the program gets more language. So fixing this will prevent this problem later.

josephbeattie commented 2 years ago

Thank you for this. Remember you can always code anything you want to, and submit a PR!

somnisomni commented 2 years ago

I'm just browsing the project repository on my phone ;) Thanks for remind, maybe I can make translation to my home language later. This project seems very cool 👍

itsWindows11 commented 2 years ago

I'm just browsing the project repository on my phone ;) maybe I can make translation to my home language later. This project seems very cool 👍

Note though, the strings aren't 100% done yet so put that in mind.

josephbeattie commented 2 years ago

Yeah. They’re not done in the slightest. :)

itsWindows11 commented 1 year ago

Should be fixed now.

BTW Crowdin translations are now open on https://crowdin.com/project/rise-media-player, so you can contribute your translations more easily.