search

Rishabh-malhotraa / caucus

Realtime Collaborate Editor with Embedded Compiler
https://caucus.rishabhmalhotra.in/
MIT License
296 stars 69 forks source link

Fix Users component on the right hand side #21

Open Rishabh-malhotraa opened 3 years ago

Rishabh-malhotraa commented 3 years ago

Describe the bug Desgin flaw first I capped the room limit to 2 people but then later I increased it to 5, but I did not change this component, also I want to show random user icon images rather than just guest user icon, because then you cannot distinguish between users.

image

To fix : Correct the socket-io code so it sends data of all the users in the room rather than the person who was last to join files:

caucus-server/src/service/socket-io-service.ts

And manage the front end part too:

caucus/src/components/VoiceChat
caucus/src/pages/room/room.tsx
deepanshu2506 commented 2 years ago

@Rishabh-malhotraa assign it to me.. i'll work on this

Rishabh-malhotraa commented 2 years ago

This is a complicated issue because of bad architectural design, but it shouldn't be that hard to fix. I'll assign you this issue, hmu on discord is you face any issue.

deepanshu2506 commented 2 years ago

is there a env file for the server?

Rishabh-malhotraa commented 2 years ago

is there a env file for the server?

It is mentioned in the prerequisites. https://github.com/Rishabh-malhotraa/caucus-server#installation